src/handlers/http/ingest.rs (3)

176-183: Panic risk: avoid unwrap() on header value parsing

to_str().unwrap() can panic on invalid header bytes. Propagate a well-formed error instead.

-    let log_source = LogSource::from(log_source.to_str().unwrap());
+    let log_source = LogSource::from(
+        log_source
+            .to_str()
+            .map_err(|_| PostError::Invalid(anyhow::anyhow!("Invalid {} header", LOG_SOURCE_KEY)))?
+    );

---

238-279: Content-Type equality is too strict; accept parameters and fix error messages

Many clients send application/json; charset=utf-8. The current equality check will reject these valid requests. Also, error messages should not advertise protobuf as acceptable given it’s explicitly unsupported now.

Apply this diff to robustly parse Content-Type and align error messages with protobuf removal:

-    match req
-        .headers()
-        .get("Content-Type")
-        .and_then(|h| h.to_str().ok())
-    {
-        Some(content_type) => {
-            if content_type == CONTENT_TYPE_JSON {
+    match req.headers().get("Content-Type").and_then(|h| h.to_str().ok()) {
+        Some(raw_content_type) => {
+            // Accept parameters like `; charset=utf-8`
+            let content_type = raw_content_type.split(';').next().unwrap_or("").trim();
+            if content_type == CONTENT_TYPE_JSON {
                 flatten_and_push_logs(
-                    serde_json::from_slice(&body)?,
+                    serde_json::from_slice(&body)?,
                     stream_name,
                     log_source,
                     &p_custom_fields,
                 )
                 .await?;
-            } else if content_type == CONTENT_TYPE_PROTOBUF {
+            } else if content_type == CONTENT_TYPE_PROTOBUF {
                 return Err(PostError::Invalid(anyhow::anyhow!(
-                    "Protobuf ingestion is not supported in Parseable OSS"
+                    "Protobuf ingestion is not supported in Parseable OSS"
                 )));
             } else {
                 return Err(PostError::Invalid(anyhow::anyhow!(
-                    "Unsupported Content-Type: {}. Expected application/json or application/x-protobuf",
-                    content_type
+                    "Unsupported Content-Type: {}. Expected application/json",
+                    raw_content_type
                 )));
             }
         }
         None => {
             return Err(PostError::Invalid(anyhow::anyhow!(
-                "Missing Content-Type header. Expected application/json or application/x-protobuf"
+                "Missing Content-Type header. Expected application/json"
             )));
         }
     }

---

238-279: No payload size guard: potential DoS via large OTEL JSON bodies

The prior 10MB guard appears to have been removed with the protobuf path. Add a conservative upper bound for JSON bodies to avoid memory spikes.

 async fn process_otel_content(
     req: &HttpRequest,
     body: web::Bytes,
     stream_name: &str,
     log_source: &LogSource,
 ) -> Result<(), PostError> {
     let p_custom_fields = get_custom_fields_from_header(req);
 
+    // Guard against excessively large payloads (10 MB)
+    const MAX_OTEL_JSON_BYTES: usize = 10 * 1024 * 1024;
+    if body.len() > MAX_OTEL_JSON_BYTES {
+        return Err(PostError::Invalid(anyhow::anyhow!(
+            "Payload too large: {} bytes (limit: {} bytes)",
+            body.len(),
+            MAX_OTEL_JSON_BYTES
+        )));
+    }
+
     match req
         .headers()
         .get("Content-Type")
         .and_then(|h| h.to_str().ok())
     {

If a global limit/config already exists elsewhere, wire it here instead of a hardcoded constant.

src/lib.rs (1)

51-51: Confirm intent of expanding public API surface (pub mod validator)

Making validator public is a breaking surface change. If external crates aren’t meant to depend on internal validation details, consider pub(crate) or re-exporting only the required items instead of the entire module.

Would you like me to prepare a targeted re-export (e.g., pub use validator::{StreamNameValidationError, stream_name};) to minimize the public surface?

src/handlers/http/ingest.rs (2)

166-171: Visibility: consider pub(crate) for setup_otel_stream unless needed externally

If this helper is only used within this crate, prefer pub(crate) to avoid unnecessary public API expansion. If you intend SDKs or integrators to call this directly, keep it public.

-pub async fn setup_otel_stream(
+pub(crate) async fn setup_otel_stream(

---

192-235: Minor: setup_otel_stream returns LogSourceEntry but it’s unused by callers

Consider returning only (String, LogSource) or reusing the entry in the caller to avoid unused data. This reduces allocations and clarifies intent.

-) -> Result<(String, LogSource, LogSourceEntry), PostError> {
+) -> Result<(String, LogSource), PostError> {
@@
-    Ok((stream_name, log_source, log_source_entry))
+    Ok((stream_name, log_source))

…and remove the unused binding at the call sites.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.